doc: fix typo in node-config-schema.json#64188
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
config
Renegade334
previously approved these changes
Jun 28, 2026
Renegade334
added
author ready
Signed-off-by: Hamid Reza Ghavami <hamidr.ghavami@gmail.com>
marco-ippolito
approved these changes
Jun 28, 2026
Renegade334
approved these changes
Jun 28, 2026
Renegade334
added
the
author ready
watilde
approved these changes
Jun 29, 2026
lpinca
approved these changes
Jun 29, 2026
Contributor
Member
|
Please don't use merge commits, they aren't compatible with our tooling. I'm going to revert the branch so that this can be landed. |
Renegade334
approved these changes
Jul 2, 2026
Renegade334
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64188 ✔ Done loading data for nodejs/node/pull/64188 ----------------------------------- PR info ------------------------------------ Title doc: fix typo in node-config-schema.json (#64188) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch hamidrezaghavami:main -> nodejs:main Labels doc, author ready, config Commits 1 - doc: fix typo in node-config-schema.json Committers 1 - Hamid Reza Ghavami <hamidr.ghavami@gmail.com> PR-URL: https://github.com/nodejs/node/pull/64188 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64188 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 28 Jun 2026 10:07:50 GMT ✔ Approvals: 4 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/64188#pullrequestreview-4588096883 ✔ - René (@Renegade334): https://github.com/nodejs/node/pull/64188#pullrequestreview-4621475897 ✔ - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/64188#pullrequestreview-4591273858 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/64188#pullrequestreview-4594926200 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/28629389108 |
Renegade334
added
needs-ci
github-actions
Bot
removed
the
request-ci
Collaborator
Renegade334
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 8a35750 |
richardlau
pushed a commit
that referenced
this pull request
Jul 3, 2026
Signed-off-by: Hamid Reza Ghavami <hamidr.ghavami@gmail.com> PR-URL: #64188 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.